Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution Washing Staiton #1616

Closed
wants to merge 1 commit into from
Closed

Conversation

Psychox1k
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the Car and CarWashStation classes! 🎉 Your code meets the task requirements and constraints effectively. Just a couple of minor tweaks to consider: ensure the calculate_washing_price method handles cases where distance_from_city_center is zero to prevent division errors, and make sure the wash_single_car method returns a value for clarity. Keep up the good work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +29 to +30
def wash_single_car(self, car: Car):
return round(self.calculate_washing_price(car), 1)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wash_single_car method should return a value. Currently, it calls calculate_washing_price and rounds the result, but it should explicitly return this value to ensure the method's purpose is clear.


def calculate_washing_price(self, car: Car) -> float:
cost = (car.comfort_class * (self.clean_power - car.clean_mark) *
self.average_rating / self.distance_from_city_center)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the calculate_washing_price method, ensure that distance_from_city_center is not zero to avoid division by zero errors. Consider adding a check or handling this case appropriately.

@Psychox1k Psychox1k closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants